Commit b1c9390f authored by Jon Hunter's avatar Jon Hunter Committed by Alexandre Belloni
Browse files

Revert "rtc: tps6586x: Fix initial enable_irq/disable_irq balance" 



Commit 1502fe0e ("rtc: tps6586x: Fix initial enable_irq/disable_irq
balance") breaks the wake-up alarm for the tps6586x. After this commit
was added RTC wake ups from suspend stopped working on the Tegra20
Ventana platform.

The problem is that this change set the 'irq_en' variable to true prior
to calling devm_request_threaded_irq() to indicate that the IRQ is
enabled, however, it was over looked that the flag IRQ_NOAUTOEN is
already set meaning that the IRQ is not enabled by default. This
prevents the IRQ from being enabled as expected. Revert this change to
fix this.

Fixes: 1502fe0e ("rtc: tps6586x: Fix initial enable_irq/disable_irq balance")
Signed-off-by: default avatarJon Hunter <jonathanh@nvidia.com>
Link: https://patch.msgid.link/20251031103741.945460-1-jonathanh@nvidia.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 3a866087

drivers/rtc/rtc-tps6586x.c

+0 −1
Original line number Diff line number Diff line
@@ -258,7 +258,6 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) 


	irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);



	rtc->irq_en = true;

	ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,

				tps6586x_rtc_irq,

				IRQF_ONESHOT,