Commit b1e44b4a authored Feb 24, 2025 by Piotr Kwapulinski Committed by Jakub Kicinski Feb 25, 2025

ixgbe: fix media cage present detection for E610 device



The commit 23c0e5a1 ("ixgbe: Add link management support for E610
device") introduced incorrect checking of media cage presence for E610
device. Fix it.

Fixes: 23c0e5a1 ("ixgbe: Add link management support for E610 device")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/e7d73b32-f12a-49d1-8b60-1ef83359ec13@stanley.mountain/


Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Bharath R <bharath.r@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20250224190647.3601930-6-anthony.l.nguyen@intel.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent c6124f6f

drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1122,7 +1122,7 @@ static bool ixgbe_is_media_cage_present(struct ixgbe_hw *hw)
		* returns error (ENOENT), then no cage present. If no cage present then
		* connection type is backplane or BASE-T.
		*/
		return ixgbe_aci_get_netlist_node(hw, cmd, NULL, NULL);
		return !ixgbe_aci_get_netlist_node(hw, cmd, NULL, NULL);
		}

		/**