Commit b20d6576 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

serial: 8250: export RSA functions 



The RSA functions moved by the below commit to 8250_rsa.c are used in
8250_base.c. Since that can be a module (when CONFIG_SERIAL_8250=m),
this causes build failures:
  ERROR: modpost: "rsa_autoconfig" [drivers/tty/serial/8250/8250_base.ko] undefined!
  ERROR: modpost: "rsa_reset" [drivers/tty/serial/8250/8250_base.ko] undefined!
  ERROR: modpost: "rsa_disable" [drivers/tty/serial/8250/8250_base.ko] undefined!
  ERROR: modpost: "rsa_enable" [drivers/tty/serial/8250/8250_base.ko] undefined!

Fix them by exporting the functions. But only to the base module using
EXPORT_SYMBOL_GPL_FOR_MODULES(). (And not to the whole world.)

Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/all/20250619165607.33403e19@canb.auug.org.au/
Fixes: 5a128fb4 ("serial: 8250: move RSA functions to 8250_rsa.c")
Link: https://lore.kernel.org/r/20250623061035.436414-1-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7dfd023d

drivers/tty/serial/8250/8250_rsa.c

+4 −0
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ void rsa_enable(struct uart_8250_port *up) 
	if (up->port.uartclk == SERIAL_RSA_BAUD_BASE * 16)

		serial_out(up, UART_RSA_FRR, 0);

}

EXPORT_SYMBOL_GPL_FOR_MODULES(rsa_enable, "8250_base");



/*

 * Attempts to turn off the RSA FIFO and resets the RSA board back to 115kbps compat mode. It is
@@ -178,6 +179,7 @@ void rsa_disable(struct uart_8250_port *up) 
		up->port.uartclk = SERIAL_RSA_BAUD_BASE_LO * 16;

	uart_port_unlock_irq(&up->port);

}

EXPORT_SYMBOL_GPL_FOR_MODULES(rsa_disable, "8250_base");



void rsa_autoconfig(struct uart_8250_port *up)

{
@@ -190,6 +192,7 @@ void rsa_autoconfig(struct uart_8250_port *up) 
	if (__rsa_enable(up))

		up->port.type = PORT_RSA;

}

EXPORT_SYMBOL_GPL_FOR_MODULES(rsa_autoconfig, "8250_base");



void rsa_reset(struct uart_8250_port *up)

{
@@ -198,6 +201,7 @@ void rsa_reset(struct uart_8250_port *up) 


	serial_out(up, UART_RSA_FRR, 0);

}

EXPORT_SYMBOL_GPL_FOR_MODULES(rsa_reset, "8250_base");



#ifdef CONFIG_SERIAL_8250_DEPRECATED_OPTIONS

#ifndef MODULE