Commit b2625182 authored by Konrad Dybcio's avatar Konrad Dybcio Committed by Bjorn Helgaas
Browse files

PCI: dwc: Use msleep() in dw_pcie_wait_for_link() 

According to [1], msleep should be used for large sleeps, such as the
100-ish ms one in this function. Comply with the guide and use it.

[1] https://docs.kernel.org/timers/timers-howto.html

[kwilczynski: commit log]
Link: https://lore.kernel.org/linux-pci/20240215-topic-pci_sleep-v2-1-79334884546b@linaro.org


Signed-off-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 96447ede

drivers/pci/controller/dwc/pcie-designware.c

+1 −1
Original line number Diff line number Diff line
@@ -655,7 +655,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) 
		if (dw_pcie_link_up(pci))

			break;



		usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX);

		msleep(LINK_WAIT_SLEEP_MS);

	}



	if (retries >= LINK_WAIT_MAX_RETRIES) {

drivers/pci/controller/dwc/pcie-designware.h

+1 −2
Original line number Diff line number Diff line
@@ -63,8 +63,7 @@ 


/* Parameters for the waiting for link up routine */

#define LINK_WAIT_MAX_RETRIES		10

#define LINK_WAIT_USLEEP_MIN		90000

#define LINK_WAIT_USLEEP_MAX		100000

#define LINK_WAIT_SLEEP_MS		90



/* Parameters for the waiting for iATU enabled routine */

#define LINK_WAIT_MAX_IATU_RETRIES	5