Commit b26e52c5 authored by Vlastimil Babka's avatar Vlastimil Babka
Browse files

slab: add SLAB_CONSISTENCY_CHECKS to SLAB_NEVER_MERGE 



All the debug flags prevent merging, except SLAB_CONSISTENCY_CHECKS. This
is suboptimal because this flag (like any debug flags) prevents the
usage of any fastpaths, and thus affect performance of any aliased
cache. Also the objects from an aliased cache than the one specified for
debugging could also interfere with the debugging efforts.

Fix this by adding the whole SLAB_DEBUG_FLAGS collection to
SLAB_NEVER_MERGE instead of individual debug flags, so it now also
includes SLAB_CONSISTENCY_CHECKS.

Reviewed-by: default avatarSuren Baghdasaryan <surenb@google.com>
Reviewed-by: default avatarHarry Yoo <harry.yoo@oracle.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
parent f8b4cd2d

mm/slab_common.c

+2 −3
Original line number Diff line number Diff line
@@ -45,9 +45,8 @@ struct kmem_cache *kmem_cache; 
/*

 * Set of flags that will prevent slab merging

 */

#define SLAB_NEVER_MERGE (SLAB_RED_ZONE | SLAB_POISON | SLAB_STORE_USER | \

		SLAB_TRACE | SLAB_TYPESAFE_BY_RCU | SLAB_NOLEAKTRACE | \

		SLAB_FAILSLAB | SLAB_NO_MERGE)

#define SLAB_NEVER_MERGE (SLAB_DEBUG_FLAGS | SLAB_TYPESAFE_BY_RCU | \

		SLAB_NOLEAKTRACE | SLAB_FAILSLAB | SLAB_NO_MERGE)



#define SLAB_MERGE_SAME (SLAB_RECLAIM_ACCOUNT | SLAB_CACHE_DMA | \

			 SLAB_CACHE_DMA32 | SLAB_ACCOUNT)