Commit b28f47ac authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: spinand: Improve spinand_info macros style 



Let's assume all these macros should not have a trailing comma, this way
the caller can use a more formal and usual C writing style, as reflected
in the Macronix driver.

Acked-by: default avatarPratyush Yadav <pratyush@kernel.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent ddc210cf

drivers/mtd/nand/spi/macronix.c

+5 −5
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ static const struct spinand_info macronix_spinand_table[] = { 
		     SPINAND_HAS_QE_BIT,

		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,

				     macronix_ecc_get_status),

		     SPINAND_CONT_READ(macronix_set_cont_read)

		     SPINAND_CONT_READ(macronix_set_cont_read),

		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,

					macronix_set_read_retry)),

	SPINAND_INFO("MX35LF4GE4AD",
@@ -200,7 +200,7 @@ static const struct spinand_info macronix_spinand_table[] = { 
		     SPINAND_HAS_QE_BIT,

		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,

				     macronix_ecc_get_status),

		     SPINAND_CONT_READ(macronix_set_cont_read)

		     SPINAND_CONT_READ(macronix_set_cont_read),

		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,

					macronix_set_read_retry)),

	SPINAND_INFO("MX35LF1G24AD",
@@ -328,7 +328,7 @@ static const struct spinand_info macronix_spinand_table[] = { 
		     SPINAND_HAS_QE_BIT,

		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,

				     macronix_ecc_get_status),

		     SPINAND_CONT_READ(macronix_set_cont_read)

		     SPINAND_CONT_READ(macronix_set_cont_read),

		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,

					macronix_set_read_retry)),

	SPINAND_INFO("MX35UF2G14AC",
@@ -378,7 +378,7 @@ static const struct spinand_info macronix_spinand_table[] = { 
		     SPINAND_HAS_QE_BIT,

		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,

				     macronix_ecc_get_status),

		     SPINAND_CONT_READ(macronix_set_cont_read)

		     SPINAND_CONT_READ(macronix_set_cont_read),

		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,

					macronix_set_read_retry)),

	SPINAND_INFO("MX35UF2GE4AC",
@@ -424,7 +424,7 @@ static const struct spinand_info macronix_spinand_table[] = { 
		     SPINAND_HAS_QE_BIT,

		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,

				     macronix_ecc_get_status),

		     SPINAND_CONT_READ(macronix_set_cont_read)

		     SPINAND_CONT_READ(macronix_set_cont_read),

		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,

					macronix_set_read_retry)),

	SPINAND_INFO("MX35UF1GE4AC",

include/linux/mtd/spinand.h

+4 −4
Original line number Diff line number Diff line
@@ -502,10 +502,10 @@ struct spinand_info { 
	}



#define SPINAND_SELECT_TARGET(__func)					\

	.select_target = __func,

	.select_target = __func



#define SPINAND_CONT_READ(__set_cont_read)				\

	.set_cont_read = __set_cont_read,

	.set_cont_read = __set_cont_read



#define SPINAND_FACT_OTP_INFO(__npages, __start_page, __ops)		\

	.fact_otp = {							\
@@ -527,7 +527,7 @@ struct spinand_info { 


#define SPINAND_READ_RETRY(__read_retries, __set_read_retry)		\

	.read_retries = __read_retries,					\

	.set_read_retry = __set_read_retry,

	.set_read_retry = __set_read_retry



#define SPINAND_INFO(__model, __id, __memorg, __eccreq, __op_variants,	\

		     __flags, ...)					\