Commit b2cf569e authored by Doug Berger's avatar Doug Berger Committed by Bartosz Golaszewski
Browse files

gpio: brcmstb: correct hwirq to bank map 



The brcmstb_gpio_hwirq_to_bank() function was designed to
accommodate the downward numbering of dynamic GPIOs by
traversing the bank list in the reverse order. However, the
dynamic numbering has changed to increment upward which can
produce an incorrect mapping.

The function is modified to no longer assume an ordering of
the list to accommodate either option.

Fixes: 7b61212f ("gpiolib: Get rid of ARCH_NR_GPIOS")
Signed-off-by: default avatarDoug Berger <opendmb@gmail.com>
Signed-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: default avatarLinus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260127214656.447333-2-florian.fainelli@broadcom.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent 730e5ebf

drivers/gpio/gpio-brcmstb.c

+3 −5
Original line number Diff line number Diff line
@@ -301,12 +301,10 @@ static struct brcmstb_gpio_bank *brcmstb_gpio_hwirq_to_bank( 
		struct brcmstb_gpio_priv *priv, irq_hw_number_t hwirq)

{

	struct brcmstb_gpio_bank *bank;

	int i = 0;



	/* banks are in descending order */

	list_for_each_entry_reverse(bank, &priv->bank_list, node) {

		i += bank->chip.gc.ngpio;

		if (hwirq < i)

	list_for_each_entry(bank, &priv->bank_list, node) {

		if (hwirq >= bank->chip.gc.offset &&

		    hwirq < (bank->chip.gc.offset + bank->chip.gc.ngpio))

			return bank;

	}

	return NULL;