Commit b33cb0cb authored by Alain Volmat's avatar Alain Volmat Committed by Hans Verkuil
Browse files

media: i2c: st-mipid02: correct format propagation 



Use a copy of the struct v4l2_subdev_format when propagating
format from the sink to source pad in order to avoid impacting the
sink format returned to the application.

Thanks to Jacopo Mondi for pointing the issue.

Fixes: 6c01e6f3 ("media: st-mipid02: Propagate format from sink to source pad")
Signed-off-by: default avatarAlain Volmat <alain.volmat@foss.st.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: default avatarDaniel Scally <dan.scally@ideasonboard.com>
Reviewed-by: default avatarBenjamin Mugnier <benjamin.mugnier@foss.st.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent c9e3e849

drivers/media/i2c/st-mipid02.c

+7 −2
Original line number Diff line number Diff line
@@ -769,6 +769,7 @@ static void mipid02_set_fmt_sink(struct v4l2_subdev *sd, 
				 struct v4l2_subdev_format *format)

{

	struct mipid02_dev *bridge = to_mipid02_dev(sd);

	struct v4l2_subdev_format source_fmt;

	struct v4l2_mbus_framefmt *fmt;



	format->format.code = get_fmt_code(format->format.code);
@@ -780,8 +781,12 @@ static void mipid02_set_fmt_sink(struct v4l2_subdev *sd, 


	*fmt = format->format;



	/* Propagate the format change to the source pad */

	mipid02_set_fmt_source(sd, sd_state, format);

	/*

	 * Propagate the format change to the source pad, taking

	 * care not to update the format pointer given back to user

	 */

	source_fmt = *format;

	mipid02_set_fmt_source(sd, sd_state, &source_fmt);

}



static int mipid02_set_fmt(struct v4l2_subdev *sd,