Commit b347cdc8 authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: spinand: macronix: Convert vendor specific operation to SPINAND_OP() 



Macronix chips require a vendor specific operation to read the ECC
status register. Instead of defining this op only in the function that
needs it, hiding it from the core, make it a proper define like all
other spi-mem operations, and implement the necessary
spinand_fill_*_op() helper to make the SPINAND_OP() macro work. This way
we can use it from any function without any extra handling outside of
this helper when we will convert the core to support octal DDR busses.

Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 88b0e358

drivers/mtd/nand/spi/macronix.c

+15 −5
Original line number Diff line number Diff line
@@ -41,6 +41,18 @@ static SPINAND_OP_VARIANTS(update_cache_variants, 
		SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),

		SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));



#define SPINAND_MACRONIX_READ_ECCSR_1S_0_1S(buf)			\

	SPI_MEM_OP(SPI_MEM_OP_CMD(0x7c, 1),				\

		   SPI_MEM_OP_NO_ADDR,					\

		   SPI_MEM_OP_DUMMY(1, 1),				\

		   SPI_MEM_OP_DATA_IN(1, buf, 1))



static struct spi_mem_op

spinand_fill_macronix_read_eccsr_op(struct spinand_device *spinand, void *valptr)

{

	return (struct spi_mem_op)SPINAND_MACRONIX_READ_ECCSR_1S_0_1S(valptr);

}



static int mx35lfxge4ab_ooblayout_ecc(struct mtd_info *mtd, int section,

				      struct mtd_oob_region *region)

{
@@ -67,12 +79,10 @@ static const struct mtd_ooblayout_ops mx35lfxge4ab_ooblayout = { 
static int macronix_get_eccsr(struct spinand_device *spinand, u8 *eccsr)

{

	struct macronix_priv *priv = spinand->priv;

	struct spi_mem_op op = SPI_MEM_OP(SPI_MEM_OP_CMD(0x7c, 1),

					  SPI_MEM_OP_NO_ADDR,

					  SPI_MEM_OP_DUMMY(1, 1),

					  SPI_MEM_OP_DATA_IN(1, eccsr, 1));

	struct spi_mem_op op = SPINAND_OP(spinand, macronix_read_eccsr, eccsr);

	int ret;



	int ret = spi_mem_exec_op(spinand->spimem, &op);

	ret = spi_mem_exec_op(spinand->spimem, &op);

	if (ret)

		return ret;