Commit b34ce4a5 authored by Hans de Goede's avatar Hans de Goede Committed by Sebastian Reichel
Browse files

power: supply: axp288_charger: Fix constant_charge_voltage writes 



info->max_cv is in millivolts, divide the microvolt value being written
to constant_charge_voltage by 1000 *before* clamping it to info->max_cv.

Before this fix the code always tried to set constant_charge_voltage
to max_cv / 1000 = 4 millivolt, which ends up in setting it to 4.1V
which is the lowest supported value.

Fixes: 843735b7 ("power: axp288_charger: axp288 charger driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240717200333.56669-1-hdegoede@redhat.com


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent d3911f16

drivers/power/supply/axp288_charger.c

+2 −2
Original line number Diff line number Diff line
@@ -337,8 +337,8 @@ static int axp288_charger_usb_set_property(struct power_supply *psy, 
		}

		break;

	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:

		scaled_val = min(val->intval, info->max_cv);

		scaled_val = DIV_ROUND_CLOSEST(scaled_val, 1000);

		scaled_val = DIV_ROUND_CLOSEST(val->intval, 1000);

		scaled_val = min(scaled_val, info->max_cv);

		ret = axp288_charger_set_cv(info, scaled_val);

		if (ret < 0) {

			dev_warn(&info->pdev->dev, "set charge voltage failed\n");