Commit b3aa09ee authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf jitdump: Avoid memory leak 



jit_repipe_unwinding_info is called in a loop by jit_process_dump,
avoid leaking unwinding_data by free-ing before overwriting. Error
detected by clang-tidy.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: llvm@lists.linux.dev
Cc: Ming Wang <wangming01@loongson.cn>
Cc: Tom Rix <trix@redhat.com>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20231009183920.200859-9-irogers@google.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent e2372136

tools/perf/util/jitdump.c

+1 −0
Original line number Diff line number Diff line
@@ -675,6 +675,7 @@ jit_repipe_unwinding_info(struct jit_buf_desc *jd, union jr_entry *jr) 
	jd->eh_frame_hdr_size = jr->unwinding.eh_frame_hdr_size;

	jd->unwinding_size = jr->unwinding.unwinding_size;

	jd->unwinding_mapped_size = jr->unwinding.mapped_size;

	free(jd->unwinding_data);

	jd->unwinding_data = unwinding_data;



	return 0;