Commit b3ba7d92 authored by Thorsten Blum's avatar Thorsten Blum Committed by Jakub Kicinski
Browse files

net/sched: Remove redundant memset(0) call in reset_policy() 



The call to nla_strscpy() already zero-pads the tail of the destination
buffer which makes the additional memset(0) call redundant. Remove it.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarJoe Damato <joe@dama.to>
Link: https://patch.msgid.link/20250811164039.43250-1-thorsten.blum@linux.dev


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 86e3d52b

net/sched/act_simple.c

+0 −1
Original line number Diff line number Diff line
@@ -72,7 +72,6 @@ static int reset_policy(struct tc_action *a, const struct nlattr *defdata, 
	d = to_defact(a);

	spin_lock_bh(&d->tcf_lock);

	goto_ch = tcf_action_set_ctrlact(a, p->action, goto_ch);

	memset(d->tcfd_defdata, 0, SIMP_MAX_DATA);

	nla_strscpy(d->tcfd_defdata, defdata, SIMP_MAX_DATA);

	spin_unlock_bh(&d->tcf_lock);

	if (goto_ch)