Unverified Commit b3c78bc5 authored by Amir Goldstein's avatar Amir Goldstein Committed by Christian Brauner
Browse files

nfsd: do not allow exporting of special kernel filesystems 



pidfs and nsfs recently gained support for encode/decode of file handles
via name_to_handle_at(2)/open_by_handle_at(2).

These special kernel filesystems have custom ->open() and ->permission()
export methods, which nfsd does not respect and it was never meant to be
used for exporting those filesystems by nfsd.

Therefore, do not allow nfsd to export filesystems with custom ->open()
or ->permission() methods.

Fixes: b3caba8f ("pidfs: implement file handle support")
Fixes: 5222470b ("nsfs: support file handles")
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Link: https://patch.msgid.link/20260129100212.49727-3-amir73il@gmail.com


Reviewed-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent a39162f7

fs/nfsd/export.c

+5 −3
Original line number Diff line number Diff line
@@ -427,7 +427,8 @@ static int check_export(const struct path *path, int *flags, unsigned char *uuid 
	 *       either a device number (so FS_REQUIRES_DEV needed)

	 *       or an FSID number (so NFSEXP_FSID or ->uuid is needed).

	 * 2:  We must be able to find an inode from a filehandle.

	 *       This means that s_export_op must be set.

	 *       This means that s_export_op must be set and comply with

	 *       the requirements for remote filesystem export.

	 * 3: We must not currently be on an idmapped mount.

	 */

	if (!(inode->i_sb->s_type->fs_flags & FS_REQUIRES_DEV) &&
@@ -437,8 +438,9 @@ static int check_export(const struct path *path, int *flags, unsigned char *uuid 
		return -EINVAL;

	}



	if (!exportfs_can_decode_fh(inode->i_sb->s_export_op)) {

		dprintk("exp_export: export of invalid fs type.\n");

	if (!exportfs_may_export(inode->i_sb->s_export_op)) {

		dprintk("exp_export: export of invalid fs type (%s).\n",

			inode->i_sb->s_type->name);

		return -EINVAL;

	}

include/linux/exportfs.h

+9 −0
Original line number Diff line number Diff line
@@ -338,6 +338,15 @@ static inline bool exportfs_can_decode_fh(const struct export_operations *nop) 
	return nop && nop->fh_to_dentry;

}



static inline bool exportfs_may_export(const struct export_operations *nop)

{

	/*

	 * Do not allow nfs export for filesystems with custom ->open() or

	 * ->permission() ops, which nfsd does not respect (e.g. pidfs, nsfs).

	 */

	return exportfs_can_decode_fh(nop) && !nop->open && !nop->permission;

}



static inline bool exportfs_can_encode_fh(const struct export_operations *nop,

					  int fh_flags)

{