Commit b400f4b8 authored by Samiullah Khawaja's avatar Samiullah Khawaja Committed by Jakub Kicinski
Browse files

page_pool: Set `dma_sync` to false for devmem memory provider 



Move the `dma_map` and `dma_sync` checks to `page_pool_init` to make
them generic. Set dma_sync to false for devmem memory provider because
the dma_sync APIs should not be used for dma_buf backed devmem memory
provider.

Cc: Jason Gunthorpe <jgg@ziepe.ca>
Signed-off-by: default avatarSamiullah Khawaja <skhawaja@google.com>
Signed-off-by: default avatarMina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20241211212033.1684197-4-almasrymina@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8156c310

net/core/devmem.c

+4 −5
Original line number Diff line number Diff line
@@ -331,11 +331,10 @@ int mp_dmabuf_devmem_init(struct page_pool *pool) 
	if (!binding)

		return -EINVAL;



	if (!pool->dma_map)

		return -EOPNOTSUPP;



	if (pool->dma_sync)

		return -EOPNOTSUPP;

	/* dma-buf dma addresses do not need and should not be used with

	 * dma_sync_for_cpu/device. Force disable dma_sync.

	 */

	pool->dma_sync = false;



	if (pool->p.order != 0)

		return -E2BIG;

net/core/page_pool.c

+3 −0
Original line number Diff line number Diff line
@@ -287,6 +287,9 @@ static int page_pool_init(struct page_pool *pool, 
	}



	if (pool->mp_priv) {

		if (!pool->dma_map || !pool->dma_sync)

			return -EOPNOTSUPP;



		err = mp_dmabuf_devmem_init(pool);

		if (err) {

			pr_warn("%s() mem-provider init failed %d\n", __func__,