Commit b415399c authored by Ivan Barrera's avatar Ivan Barrera Committed by Leon Romanovsky
Browse files

RDMA/irdma: Clean up unnecessary dereference of event->cm_node 



The cm_node is available and the usage of cm_node and event->cm_node
seems arbitrary. Clean up unnecessary dereference of event->cm_node.

Fixes: 146b9756 ("RDMA/irdma: Add connection manager")
Signed-off-by: default avatarIvan Barrera <ivan.d.barrera@intel.com>
Signed-off-by: default avatarTatyana Nikolova <tatyana.e.nikolova@intel.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 5e8f0239

drivers/infiniband/hw/irdma/cm.c

+6 −6
Original line number Diff line number Diff line
@@ -4239,21 +4239,21 @@ static void irdma_cm_event_handler(struct work_struct *work) 
		irdma_cm_event_reset(event);

		break;

	case IRDMA_CM_EVENT_CONNECTED:

		if (!event->cm_node->cm_id ||

		    event->cm_node->state != IRDMA_CM_STATE_OFFLOADED)

		if (!cm_node->cm_id ||

		    cm_node->state != IRDMA_CM_STATE_OFFLOADED)

			break;

		irdma_cm_event_connected(event);

		break;

	case IRDMA_CM_EVENT_MPA_REJECT:

		if (!event->cm_node->cm_id ||

		if (!cm_node->cm_id ||

		    cm_node->state == IRDMA_CM_STATE_OFFLOADED)

			break;

		irdma_send_cm_event(cm_node, cm_node->cm_id,

				    IW_CM_EVENT_CONNECT_REPLY, -ECONNREFUSED);

		break;

	case IRDMA_CM_EVENT_ABORTED:

		if (!event->cm_node->cm_id ||

		    event->cm_node->state == IRDMA_CM_STATE_OFFLOADED)

		if (!cm_node->cm_id ||

		    cm_node->state == IRDMA_CM_STATE_OFFLOADED)

			break;

		irdma_event_connect_error(event);

		break;
@@ -4263,7 +4263,7 @@ static void irdma_cm_event_handler(struct work_struct *work) 
		break;

	}



	irdma_rem_ref_cm_node(event->cm_node);

	irdma_rem_ref_cm_node(cm_node);

	kfree(event);

}