Commit b41f8638 authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: VMX: Isolate pure loads from atomic XCHG when processing PIR 



Rework KVM's processing of the PIR to use the same algorithm as posted
MSIs, i.e. to do READ(x4) => XCHG(x4) instead of (READ+XCHG)(x4).  Given
KVM's long-standing, sub-optimal use of 32-bit accesses to the PIR, it's
safe to say far more thought and investigation was put into handling the
PIR for posted MSIs, i.e. there's no reason to assume KVM's existing
logic is meaningful, let alone superior.

Matching the processing done by posted MSIs will also allow deduplicating
the code between KVM and posted MSIs.

See the comment for handle_pending_pir() added by commit 1b03d82b
("x86/irq: Install posted MSI notification handler") for details on
why isolating loads from XCHG is desirable.

Suggested-by: default avatarJim Mattson <jmattson@google.com>
Link: https://lore.kernel.org/r/20250401163447.846608-7-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 06b4d0ea

arch/x86/kvm/lapic.c

+8 −1
Original line number Diff line number Diff line
@@ -657,7 +657,7 @@ static u8 count_vectors(void *bitmap) 


bool __kvm_apic_update_irr(unsigned long *pir, void *regs, int *max_irr)

{

	unsigned long pir_vals[NR_PIR_WORDS];

	unsigned long pir_vals[NR_PIR_WORDS], pending = 0;

	u32 *__pir = (void *)pir_vals;

	u32 i, vec;

	u32 irr_val, prev_irr_val;
@@ -668,6 +668,13 @@ bool __kvm_apic_update_irr(unsigned long *pir, void *regs, int *max_irr) 


	for (i = 0; i < NR_PIR_WORDS; i++) {

		pir_vals[i] = READ_ONCE(pir[i]);

		pending |= pir_vals[i];

	}



	if (!pending)

		return false;



	for (i = 0; i < NR_PIR_WORDS; i++) {

		if (!pir_vals[i])

			continue;