Commit b427ac40 authored by Dhananjay Ugwekar's avatar Dhananjay Ugwekar Committed by Mario Limonciello
Browse files

cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call 



amd_pstate_set_driver() is called twice, once in amd_pstate_init() and once
as part of amd_pstate_register_driver(). Move around code and eliminate
the redundancy.

Signed-off-by: default avatarDhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20241017100528.300143-5-Dhananjay.Ugwekar@amd.com


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
parent 162cfa4e

drivers/cpufreq/amd-pstate.c

+4 −8
Original line number Diff line number Diff line
@@ -1848,9 +1848,11 @@ static int __init amd_pstate_init(void) 
		return -ENODEV;

	}



	ret = amd_pstate_set_driver(cppc_state);

	if (ret)

	ret = amd_pstate_register_driver(cppc_state);

	if (ret) {

		pr_err("failed to register with return %d\n", ret);

		return ret;

	}



	/* capability check */

	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
@@ -1870,12 +1872,6 @@ static int __init amd_pstate_init(void) 
			return ret;

	}



	ret = amd_pstate_register_driver(cppc_state);

	if (ret) {

		pr_err("failed to register with return %d\n", ret);

		return ret;

	}



	dev_root = bus_get_dev_root(&cpu_subsys);

	if (dev_root) {

		ret = sysfs_create_group(&dev_root->kobj, &amd_pstate_global_attr_group);