Commit b47bc7c0 authored by Nikola Z. Ivanov's avatar Nikola Z. Ivanov Committed by Wolfram Sang
Browse files

i2c: Compare the return value of gpiod_get_direction against GPIO_LINE_DIRECTION_OUT 



The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to
gpio consumers.h by breaking them out in a separate defs.h file.

Use this to validate the gpio direction instead of the hard-coded literal.

Signed-off-by: default avatarNikola Z. Ivanov <zlatistiv@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
parent 617eb7c0

drivers/i2c/i2c-core-base.c

+1 −2
Original line number Diff line number Diff line
@@ -445,8 +445,7 @@ static int i2c_init_recovery(struct i2c_adapter *adap) 
		bri->set_scl = set_scl_gpio_value;

		if (bri->sda_gpiod) {

			bri->get_sda = get_sda_gpio_value;

			/* FIXME: add proper flag instead of '0' once available */

			if (gpiod_get_direction(bri->sda_gpiod) == 0)

			if (gpiod_get_direction(bri->sda_gpiod) == GPIO_LINE_DIRECTION_OUT)

				bri->set_sda = set_sda_gpio_value;

		}

	} else if (bri->recover_bus == i2c_generic_scl_recovery) {