Commit b4a53519 authored Mar 10, 2026 by Joe Lawrence Committed by Josh Poimboeuf Mar 16, 2026

livepatch/klp-build: fix shellcheck complaints



Fix or suppress the following shellcheck warnings:

  In klp-build line 57:
  	command grep "$@" || true
                               ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

Fix the following warning:

  In klp-build line 565:
  		local file_dir="$(dirname "$file")"
                        ^------^ SC2034 (warning): file_dir appears unused. Verify use (or export if used externally).

Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
Link: https://patch.msgid.link/20260310203751.1479229-8-joe.lawrence@redhat.com


Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

parent 0573bcc4

scripts/livepatch/klp-build

+1 −1

Original line number	Diff line number	Diff line
		@@ -53,6 +53,7 @@ PATCH_TMP_DIR="$TMP_DIR/tmp"
		KLP_DIFF_LOG="$DIFF_DIR/diff.log"

		grep0() {
		# shellcheck disable=SC2317
		command grep "$@" \|\| true
		}

		@@ -550,7 +551,6 @@ copy_orig_objects() {
		for _file in "${files[@]}"; do
		local rel_file="${_file/.ko/.o}"
		local file="$OBJ/$rel_file"
		local file_dir="$(dirname "$file")"
		local orig_file="$ORIG_DIR/$rel_file"
		local orig_dir="$(dirname "$orig_file")"