Commit b4af7d19 authored by David LaPorte's avatar David LaPorte Committed by Miquel Raynal
Browse files

mtd: spinand: Disable continuous read during probe



Macronix serial NAND devices with continuous read support do not
clear the configuration register on soft reset and lack a hardware
reset pin. When continuous read is interrupted (e.g., during reboot),
the feature remains enabled at the device level.

With continuous read enabled, the OOB area becomes inaccessible and
all reads are instead directed to the main area. As a result, during
partition allocation as part of MTD device registration, the first two
bytes of the main area for the master block are read and indicate that
the block is bad. This process repeats for every subsequent block for
the partition.

All reads and writes that reference the BBT find no good blocks and
fail.

The only paths for recovery from this state are triggering the
continuous read feature by way of raw MTD reads or through a NAND
device power drain.

Disable continuous read explicitly during spinand probe to ensure
quiescent feature state.

Fixes: 631cfdd0 ("mtd: spi-nand: Add continuous read support")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDavid LaPorte <dalaport@amazon.com>
Reviewed-by: default avatarGunnar Kudrjavets <gunnarku@amazon.com>
Reviewed-by: default avatarMikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 1d9d5f5a
Loading
Loading
Loading
Loading
+8 −0
Original line number Diff line number Diff line
@@ -940,6 +940,14 @@ static void spinand_cont_read_init(struct spinand_device *spinand)
	    (engine_type == NAND_ECC_ENGINE_TYPE_ON_DIE ||
	     engine_type == NAND_ECC_ENGINE_TYPE_NONE)) {
		spinand->cont_read_possible = true;

		/*
		 * Ensure continuous read is disabled on probe.
		 * Some devices retain this state across soft reset,
		 * which leaves the OOB area inaccessible and results
		 * in false positive returns from spinand_isbad().
		 */
		spinand_cont_read_enable(spinand, false);
	}
}