Commit b4ba1207 authored by Jason Wang's avatar Jason Wang Committed by Michael S. Tsirkin
Browse files

vhost: fail early when __vhost_add_used() fails 



This patch fails vhost_add_used_n() early when __vhost_add_used()
fails to make sure used idx is not updated with stale used ring
information.

Reported-by: default avatarEugenio Pérez <eperezma@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Message-Id: <20250714084755.11921-2-jasowang@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Tested-by: default avatarLei Yang <leiyang@redhat.com>
parent 7d9896e9

drivers/vhost/vhost.c

+3 −0
Original line number Diff line number Diff line
@@ -2983,6 +2983,9 @@ int vhost_add_used_n(struct vhost_virtqueue *vq, struct vring_used_elem *heads, 
	}

	r = __vhost_add_used_n(vq, heads, count);



	if (r < 0)

		return r;



	/* Make sure buffer is written before we update index. */

	smp_wmb();

	if (vhost_put_used_idx(vq)) {