Commit b4c61e54 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

usb: ohci-nxp: fix device leak on probe failure 



Make sure to drop the reference taken when looking up the PHY I2C device
during probe on probe failure (e.g. probe deferral) and on driver
unbind.

Fixes: 73108aa9 ("USB: ohci-nxp: Use isp1301 driver")
Cc: stable@vger.kernel.org	# 3.5
Reported-by: default avatarMa Ke <make24@iscas.ac.cn>
Link: https://lore.kernel.org/lkml/20251117013428.21840-1-make24@iscas.ac.cn/


Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Reviewed-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Link: https://patch.msgid.link/20251218153519.19453-4-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b4b64fda

drivers/usb/host/ohci-nxp.c

+2 −0
Original line number Diff line number Diff line
@@ -223,6 +223,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev) 
fail_resource:

	usb_put_hcd(hcd);

fail_disable:

	put_device(&isp1301_i2c_client->dev);

	isp1301_i2c_client = NULL;

	return ret;

}
@@ -234,6 +235,7 @@ static void ohci_hcd_nxp_remove(struct platform_device *pdev) 
	usb_remove_hcd(hcd);

	ohci_nxp_stop_hc();

	usb_put_hcd(hcd);

	put_device(&isp1301_i2c_client->dev);

	isp1301_i2c_client = NULL;

}