Commit b4cc8180 authored by Markus Elfring's avatar Markus Elfring Committed by Andi Shyti
Browse files

i2c: stm32: Omit two variable reassignments in stm32_i2c_dma_request() 



An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete two redundant variable reassignments.

The source code was transformed by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/f7e0c023-d2d1-40ba-badb-74a7e9c23684@web.de
parent acff9f26

drivers/i2c/busses/i2c-stm32.c

+3 −4
Original line number Diff line number Diff line
@@ -27,8 +27,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev, 
	if (IS_ERR(dma->chan_tx)) {

		ret = PTR_ERR(dma->chan_tx);

		if (ret != -ENODEV)

			ret = dev_err_probe(dev, ret,

					    "can't request DMA tx channel\n");

			dev_err_probe(dev, ret, "can't request DMA tx channel\n");



		goto fail_al;

	}
@@ -48,8 +48,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev, 
	if (IS_ERR(dma->chan_rx)) {

		ret = PTR_ERR(dma->chan_rx);

		if (ret != -ENODEV)

			ret = dev_err_probe(dev, ret,

					    "can't request DMA rx channel\n");

			dev_err_probe(dev, ret, "can't request DMA rx channel\n");



		goto fail_tx;

	}