Commit b4d82395 authored by Eduard Zingerman's avatar Eduard Zingerman Committed by Alexei Starovoitov
Browse files

bpf: print full verifier states on infinite loop detection 



Additional logging in is_state_visited(): if infinite loop is detected
print full verifier state for both current and equivalent states.

Acked-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarEduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20231024000917.12153-8-eddyz87@gmail.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 64870fee

kernel/bpf/verifier.c

+4 −0
Original line number Diff line number Diff line
@@ -16928,6 +16928,10 @@ static int is_state_visited(struct bpf_verifier_env *env, int insn_idx) 
			    !iter_active_depths_differ(&sl->state, cur)) {

				verbose_linfo(env, insn_idx, "; ");

				verbose(env, "infinite loop detected at insn %d\n", insn_idx);

				verbose(env, "cur state:");

				print_verifier_state(env, cur->frame[cur->curframe], true);

				verbose(env, "old state:");

				print_verifier_state(env, sl->state.frame[cur->curframe], true);

				return -EINVAL;

			}

			/* if the verifier is processing a loop, avoid adding new state