Commit b4fcd63f authored by Ignat Korchagin's avatar Ignat Korchagin Committed by Jakub Kicinski
Browse files

net: ieee802154: do not leave a dangling sk pointer in ieee802154_create() 



sock_init_data() attaches the allocated sk object to the provided sock
object. If ieee802154_create() fails later, the allocated sk object is
freed, but the dangling pointer remains in the provided sock object, which
may allow use-after-free.

Clear the sk pointer in the sock object on error.

Signed-off-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
Reviewed-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241014153808.51894-6-ignat@cloudflare.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 811a7ca7

net/ieee802154/socket.c

+7 −5
Original line number Diff line number Diff line
@@ -1043,19 +1043,21 @@ static int ieee802154_create(struct net *net, struct socket *sock, 


	if (sk->sk_prot->hash) {

		rc = sk->sk_prot->hash(sk);

		if (rc) {

			sk_common_release(sk);

			goto out;

		}

		if (rc)

			goto out_sk_release;

	}



	if (sk->sk_prot->init) {

		rc = sk->sk_prot->init(sk);

		if (rc)

			sk_common_release(sk);

			goto out_sk_release;

	}

out:

	return rc;

out_sk_release:

	sk_common_release(sk);

	sock->sk = NULL;

	goto out;

}



static const struct net_proto_family ieee802154_family_ops = {