Commit b50155cb authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Rafael J. Wysocki
Browse files

powercap: dtpm_cpu: Fix error check against freq_qos_add_request() 



The caller of the function freq_qos_add_request() checks again a non
zero value but freq_qos_add_request() can return '1' if the request
already exists. Therefore, the setup function fails while the QoS
request actually did not failed.

Fix that by changing the check against a negative value like all the
other callers of the function.

Fixes: 0e8f68d7 ("Add CPU energy model based support")
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 4add6e84

drivers/powercap/dtpm_cpu.c

+1 −1
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent) 
	ret = freq_qos_add_request(&policy->constraints,

				   &dtpm_cpu->qos_req, FREQ_QOS_MAX,

				   pd->table[pd->nr_perf_states - 1].frequency);

	if (ret)

	if (ret < 0)

		goto out_dtpm_unregister;



	cpufreq_cpu_put(policy);