Commit b5060c17 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Suzuki K Poulose
Browse files

coresight: configfs: Constify struct config_item_type 



'struct config_item_type' is not modified in this driver.

These structures are only used with config_group_init_type_name() which
takes a "const struct config_item_type *" as a 3rd argument or with
struct config_group.cg_item.ci_type which is also a "const struct
config_item_type	*".

Constifying this structure moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   4904	   1376	    136	   6416	   1910	drivers/hwtracing/coresight/coresight-syscfg-configfs.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   5264	   1120	     16	   6400	   1900	drivers/hwtracing/coresight/coresight-syscfg-configfs.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarJames Clark <james.clark@linaro.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/1011717e5ed35ec12113a0d8c233823e820fb524.1723368522.git.christophe.jaillet@wanadoo.fr
parent 4a29fa26

drivers/hwtracing/coresight/coresight-syscfg-configfs.c

+6 −6
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ static struct configfs_attribute *cscfg_config_view_attrs[] = { 
	NULL,

};



static struct config_item_type cscfg_config_view_type = {

static const struct config_item_type cscfg_config_view_type = {

	.ct_owner = THIS_MODULE,

	.ct_attrs = cscfg_config_view_attrs,

};
@@ -170,7 +170,7 @@ static struct configfs_attribute *cscfg_config_preset_attrs[] = { 
	NULL,

};



static struct config_item_type cscfg_config_preset_type = {

static const struct config_item_type cscfg_config_preset_type = {

	.ct_owner = THIS_MODULE,

	.ct_attrs = cscfg_config_preset_attrs,

};
@@ -272,7 +272,7 @@ static struct configfs_attribute *cscfg_feature_view_attrs[] = { 
	NULL,

};



static struct config_item_type cscfg_feature_view_type = {

static const struct config_item_type cscfg_feature_view_type = {

	.ct_owner = THIS_MODULE,

	.ct_attrs = cscfg_feature_view_attrs,

};
@@ -309,7 +309,7 @@ static struct configfs_attribute *cscfg_param_view_attrs[] = { 
	NULL,

};



static struct config_item_type cscfg_param_view_type = {

static const struct config_item_type cscfg_param_view_type = {

	.ct_owner = THIS_MODULE,

	.ct_attrs = cscfg_param_view_attrs,

};
@@ -380,7 +380,7 @@ static struct config_group *cscfg_create_feature_group(struct cscfg_feature_desc 
	return &feat_view->group;

}



static struct config_item_type cscfg_configs_type = {

static const struct config_item_type cscfg_configs_type = {

	.ct_owner = THIS_MODULE,

};
@@ -414,7 +414,7 @@ void cscfg_configfs_del_config(struct cscfg_config_desc *config_desc) 
	}

}



static struct config_item_type cscfg_features_type = {

static const struct config_item_type cscfg_features_type = {

	.ct_owner = THIS_MODULE,

};