Unverified Commit b53cc614 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: codecs: wsa883x: fix PA volume control 



The PA gain can be set in steps of 1.5 dB from -3 dB to 18 dB, that is,
in 15 levels.

Fix the dB values for the PA volume control as experiments using wsa8835
show that the first 16 levels all map to the same lowest gain while the
last three map to the highest gain.

These values specifically need to be correct for the sound server to
provide proper volume control.

Note that level 0 (-3 dB) does not mute the PA so the mute flag should
also not be set.

Fixes: cdb09e62 ("ASoC: codecs: wsa883x: add control, dapm widgets and map")
Cc: stable@vger.kernel.org      # 6.0
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://msgid.link/r/20240119112420.7446-2-johan+linaro@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6613476e

sound/soc/codecs/wsa883x.c

+5 −1
Original line number Diff line number Diff line
@@ -1098,7 +1098,11 @@ static int wsa_dev_mode_put(struct snd_kcontrol *kcontrol, 
	return 1;

}



static const DECLARE_TLV_DB_SCALE(pa_gain, -300, 150, -300);

static const SNDRV_CTL_TLVD_DECLARE_DB_RANGE(pa_gain,

	0, 14, TLV_DB_SCALE_ITEM(-300, 0, 0),

	15, 29, TLV_DB_SCALE_ITEM(-300, 150, 0),

	30, 31, TLV_DB_SCALE_ITEM(1800, 0, 0),

);



static int wsa883x_get_swr_port(struct snd_kcontrol *kcontrol,

				struct snd_ctl_elem_value *ucontrol)