Commit b540de9e authored by Shuhao Fu's avatar Shuhao Fu Committed by Steve French
Browse files

smb: client: fix refcount leak in smb2_set_path_attr 



Fix refcount leak in `smb2_set_path_attr` when path conversion fails.

Function `cifs_get_writable_path` returns `cfile` with its reference
counter `cfile->count` increased on success. Function `smb2_compound_op`
would decrease the reference counter for `cfile`, as stated in its
comment. By calling `smb2_rename_path`, the reference counter of `cfile`
would leak if `cifs_convert_path_to_utf16` fails in `smb2_set_path_attr`.

Fixes: 8de9e86c ("cifs: create a helper to find a writeable handle by path name")
Acked-by: default avatarHenrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: default avatarShuhao Fu <sfual@cse.ust.hk>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 734e9962

fs/smb/client/smb2inode.c

+2 −0
Original line number Diff line number Diff line
@@ -1294,6 +1294,8 @@ static int smb2_set_path_attr(const unsigned int xid, struct cifs_tcon *tcon, 
	smb2_to_name = cifs_convert_path_to_utf16(to_name, cifs_sb);

	if (smb2_to_name == NULL) {

		rc = -ENOMEM;

		if (cfile)

			cifsFileInfo_put(cfile);

		goto smb2_rename_path;

	}

	in_iov.iov_base = smb2_to_name;