Commit b559b68d authored by Imre Deak's avatar Imre Deak
Browse files

drm/dp_mst: Simplify error path in drm_dp_mst_handle_down_rep() 



Simplify the error return path in drm_dp_mst_handle_down_rep(),
preparing for the next patch.

While at it use reset_msg_rx_state() instead of open-coding it.

Cc: Lyude Paul <lyude@redhat.com>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241203160223.2926014-4-imre.deak@intel.com
parent 4d49e77a

drivers/gpu/drm/display/drm_dp_mst_topology.c

+1 −6
Original line number Diff line number Diff line
@@ -4013,9 +4013,6 @@ static int drm_dp_mst_handle_down_rep(struct drm_dp_mst_topology_mgr *mgr) 
			    txmsg->reply.u.nak.nak_data);

	}



	memset(msg, 0, sizeof(struct drm_dp_sideband_msg_rx));

	drm_dp_mst_topology_put_mstb(mstb);



	mutex_lock(&mgr->qlock);

	txmsg->state = DRM_DP_SIDEBAND_TX_RX;

	list_del(&txmsg->next);
@@ -4023,10 +4020,8 @@ static int drm_dp_mst_handle_down_rep(struct drm_dp_mst_topology_mgr *mgr) 


	wake_up_all(&mgr->tx_waitq);



	return 0;



out_clear_reply:

	memset(msg, 0, sizeof(struct drm_dp_sideband_msg_rx));

	reset_msg_rx_state(msg);

out:

	if (mstb)

		drm_dp_mst_topology_put_mstb(mstb);