Commit b55b88d8 authored by Abhinav Kumar's avatar Abhinav Kumar Committed by Dmitry Baryshkov
Browse files

drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack() 



Currently the size parameter of drm_dp_vsc_sdp_pack() is always
the size of struct dp_sdp. Hence lets drop this parameter and
use sizeof() directly.

Suggested-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Acked-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240220195348.1270854-2-quic_abhinavk@quicinc.com
parent 47f419e0

drivers/gpu/drm/display/drm_dp_helper.c

+2 −6
Original line number Diff line number Diff line
@@ -2918,19 +2918,15 @@ EXPORT_SYMBOL(drm_dp_vsc_sdp_log); 
 * @vsc: vsc sdp initialized according to its purpose as defined in

 *       table 2-118 - table 2-120 in DP 1.4a specification

 * @sdp: valid handle to the generic dp_sdp which will be packed

 * @size: valid size of the passed sdp handle

 *

 * Returns length of sdp on success and error code on failure

 */

ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,

			    struct dp_sdp *sdp, size_t size)

			    struct dp_sdp *sdp)

{

	size_t length = sizeof(struct dp_sdp);



	if (size < length)

		return -ENOSPC;



	memset(sdp, 0, size);

	memset(sdp, 0, sizeof(struct dp_sdp));



	/*

	 * Prepare VSC Header for SU as per DP 1.4a spec, Table 2-119

drivers/gpu/drm/i915/display/intel_dp.c

+1 −2
Original line number Diff line number Diff line
@@ -4202,8 +4202,7 @@ static void intel_write_dp_sdp(struct intel_encoder *encoder, 


	switch (type) {

	case DP_SDP_VSC:

		len = drm_dp_vsc_sdp_pack(&crtc_state->infoframes.vsc, &sdp,

					  sizeof(sdp));

		len = drm_dp_vsc_sdp_pack(&crtc_state->infoframes.vsc, &sdp);

		break;

	case HDMI_PACKET_TYPE_GAMUT_METADATA:

		len = intel_dp_hdr_metadata_infoframe_sdp_pack(dev_priv,

include/drm/display/drm_dp_helper.h

+1 −2
Original line number Diff line number Diff line
@@ -812,7 +812,6 @@ int drm_dp_bw_overhead(int lane_count, int hactive, 
		       int bpp_x16, unsigned long flags);

int drm_dp_bw_channel_coding_efficiency(bool is_uhbr);



ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,

			    struct dp_sdp *sdp, size_t size);

ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, struct dp_sdp *sdp);



#endif /* _DRM_DP_HELPER_H_ */