Unverified Commit b5a5a16e authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Ilpo Järvinen
Browse files

platform/x86: xiaomi-wmi: Use devm_mutex_init() 



Use devm_mutex_init() instead of hand-writing it.

This saves some LoC, improves readability and saves some space in the
generated .o file.

Before:
======
   text	   data	    bss	    dec	    hex	filename
   3520	   1112	     64	   4696	   1258	drivers/platform/x86/xiaomi-wmi.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   3069	   1040	     64	   4173	   104d	drivers/platform/x86/xiaomi-wmi.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/bb5d7a57e11eb580f610276a351a01a993341fb8.1757239732.git.christophe.jaillet@wanadoo.fr


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent f4902538

drivers/platform/x86/xiaomi-wmi.c

+1 −9
Original line number Diff line number Diff line
@@ -26,13 +26,6 @@ struct xiaomi_wmi { 
	unsigned int key_code;

};



static void xiaomi_mutex_destroy(void *data)

{

	struct mutex *lock = data;



	mutex_destroy(lock);

}



static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)

{

	struct xiaomi_wmi *data;
@@ -46,8 +39,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context) 
		return -ENOMEM;

	dev_set_drvdata(&wdev->dev, data);



	mutex_init(&data->key_lock);

	ret = devm_add_action_or_reset(&wdev->dev, xiaomi_mutex_destroy, &data->key_lock);

	ret = devm_mutex_init(&wdev->dev, &data->key_lock);

	if (ret < 0)

		return ret;