Unverified Commit b5ba648a authored by Al Viro's avatar Al Viro Committed by Christian Brauner
Browse files

proc_fd_getattr(): don't bother with S_ISDIR() check 



that thing is callable only as ->i_op->getattr() instance and only
for directory inodes (/proc/*/fd and /proc/*/task/*/fd)

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Link: https://lore.kernel.org/20250615003321.GC3011112@ZenIV


Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 88b1de54

fs/proc/fd.c

+1 −10
Original line number Diff line number Diff line
@@ -352,18 +352,9 @@ static int proc_fd_getattr(struct mnt_idmap *idmap, 
			u32 request_mask, unsigned int query_flags)

{

	struct inode *inode = d_inode(path->dentry);

	int rv = 0;



	generic_fillattr(&nop_mnt_idmap, request_mask, inode, stat);



	/* If it's a directory, put the number of open fds there */

	if (S_ISDIR(inode->i_mode)) {

		rv = proc_readfd_count(inode, &stat->size);

		if (rv < 0)

			return rv;

	}



	return rv;

	return proc_readfd_count(inode, &stat->size);

}



const struct inode_operations proc_fd_inode_operations = {