Commit b5ef45e6 authored by Lifeng Zheng's avatar Lifeng Zheng Committed by Rafael J. Wysocki
Browse files

ACPI: CPPC: Extract cppc_get_reg_val_in_pcc() 



Extract the operations if register is in pcc out from cppc_get_reg_val()
as cppc_get_reg_val_in_pcc().

Reviewed-by: default avatarPierre Gondois <pierre.gondois@arm.com>
Signed-off-by: default avatarLifeng Zheng <zhenglifeng1@huawei.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://patch.msgid.link/20250411093855.982491-5-zhenglifeng1@huawei.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 714d103c

drivers/acpi/cppc_acpi.c

+27 −23
Original line number Diff line number Diff line
@@ -1179,29 +1179,8 @@ static int cpc_write(int cpu, struct cpc_register_resource *reg_res, u64 val) 
	return ret_val;

}



static int cppc_get_reg_val(int cpu, enum cppc_regs reg_idx, u64 *val)

static int cppc_get_reg_val_in_pcc(int cpu, struct cpc_register_resource *reg, u64 *val)

{

	struct cpc_desc *cpc_desc = per_cpu(cpc_desc_ptr, cpu);

	struct cpc_register_resource *reg;



	if (val == NULL)

		return -EINVAL;



	if (!cpc_desc) {

		pr_debug("No CPC descriptor for CPU:%d\n", cpu);

		return -ENODEV;

	}



	reg = &cpc_desc->cpc_regs[reg_idx];



	if ((reg->type == ACPI_TYPE_INTEGER && IS_OPTIONAL_CPC_REG(reg_idx) &&

	     !reg->cpc_entry.int_value) || (reg->type != ACPI_TYPE_INTEGER &&

	     IS_NULL_REG(&reg->cpc_entry.reg))) {

		pr_debug("CPC register is not supported\n");

		return -EOPNOTSUPP;

	}



	if (CPC_IN_PCC(reg)) {

	int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, cpu);

	struct cppc_pcc_data *pcc_ss_data = NULL;

	int ret;
@@ -1225,6 +1204,31 @@ static int cppc_get_reg_val(int cpu, enum cppc_regs reg_idx, u64 *val) 
	return ret;

}



static int cppc_get_reg_val(int cpu, enum cppc_regs reg_idx, u64 *val)

{

	struct cpc_desc *cpc_desc = per_cpu(cpc_desc_ptr, cpu);

	struct cpc_register_resource *reg;



	if (val == NULL)

		return -EINVAL;



	if (!cpc_desc) {

		pr_debug("No CPC descriptor for CPU:%d\n", cpu);

		return -ENODEV;

	}



	reg = &cpc_desc->cpc_regs[reg_idx];



	if ((reg->type == ACPI_TYPE_INTEGER && IS_OPTIONAL_CPC_REG(reg_idx) &&

	     !reg->cpc_entry.int_value) || (reg->type != ACPI_TYPE_INTEGER &&

	     IS_NULL_REG(&reg->cpc_entry.reg))) {

		pr_debug("CPC register is not supported\n");

		return -EOPNOTSUPP;

	}



	if (CPC_IN_PCC(reg))

		return cppc_get_reg_val_in_pcc(cpu, reg, val);



	return cpc_read(cpu, reg, val);

}