Commit b6041c9e authored by Dan Carpenter's avatar Dan Carpenter Committed by Laurent Pinchart
Browse files

media: bcm2835-unicam: Fix a NULL vs IS_ERR() check 



The media_pad_remote_pad_unique() function returns error pointers, not
NULL.  Update the check accordingly.

Fixes: 392cd78d ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/fbbe7862-2820-44eb-81cb-7f33b99cca35@moroto.mountain


Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent 0cc50ced

drivers/media/platform/broadcom/bcm2835-unicam.c

+2 −2
Original line number Diff line number Diff line
@@ -2433,9 +2433,9 @@ static int unicam_async_bound(struct v4l2_async_notifier *notifier, 
		return ret;



	source = media_pad_remote_pad_unique(sink);

	if (!source) {

	if (IS_ERR(source)) {

		dev_err(unicam->dev, "No connected sensor pad\n");

		return -ENOTCONN;

		return PTR_ERR(source);

	}



	unicam->sensor.subdev = subdev;