Commit b60521ef authored by Konrad Dybcio's avatar Konrad Dybcio Committed by Bjorn Andersson
Browse files

clk: qcom: gcc-x1e80100: Unregister GCC_GPU_CFG_AHB_CLK/GCC_DISP_XO_CLK 



The GPU clock is required for CPU access to GPUSS registers. It was
previously decided (on this and many more platforms) that the added
overhead/hassle introduced by keeping track of it would not bring much
measurable improvement in the power department.

The display clock is basically the same story over again.

Now, we're past that discussion and this commit is not trying to change
that. Instead, the clocks are both force-enabled in .probe *and*
registered with the common clock framework, resulting in them being
toggled off after ignore_unused.

Unregister said clocks to fix breakage when clk_ignore_unused is absent
(as it should be).

Fixes: 161b7c40 ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100")
Signed-off-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250111-topic-x1e_fixups-v1-1-77dc39237c12@oss.qualcomm.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 2014c95a

drivers/clk/qcom/gcc-x1e80100.c

+0 −30
Original line number Diff line number Diff line
@@ -2564,19 +2564,6 @@ static struct clk_branch gcc_disp_hf_axi_clk = { 
	},

};



static struct clk_branch gcc_disp_xo_clk = {

	.halt_reg = 0x27018,

	.halt_check = BRANCH_HALT,

	.clkr = {

		.enable_reg = 0x27018,

		.enable_mask = BIT(0),

		.hw.init = &(const struct clk_init_data) {

			.name = "gcc_disp_xo_clk",

			.ops = &clk_branch2_ops,

		},

	},

};



static struct clk_branch gcc_gp1_clk = {

	.halt_reg = 0x64000,

	.halt_check = BRANCH_HALT,
@@ -2631,21 +2618,6 @@ static struct clk_branch gcc_gp3_clk = { 
	},

};



static struct clk_branch gcc_gpu_cfg_ahb_clk = {

	.halt_reg = 0x71004,

	.halt_check = BRANCH_HALT_VOTED,

	.hwcg_reg = 0x71004,

	.hwcg_bit = 1,

	.clkr = {

		.enable_reg = 0x71004,

		.enable_mask = BIT(0),

		.hw.init = &(const struct clk_init_data) {

			.name = "gcc_gpu_cfg_ahb_clk",

			.ops = &clk_branch2_ops,

		},

	},

};



static struct clk_branch gcc_gpu_gpll0_cph_clk_src = {

	.halt_check = BRANCH_HALT_DELAY,

	.clkr = {
@@ -6268,7 +6240,6 @@ static struct clk_regmap *gcc_x1e80100_clocks[] = { 
	[GCC_CNOC_PCIE_TUNNEL_CLK] = &gcc_cnoc_pcie_tunnel_clk.clkr,

	[GCC_DDRSS_GPU_AXI_CLK] = &gcc_ddrss_gpu_axi_clk.clkr,

	[GCC_DISP_HF_AXI_CLK] = &gcc_disp_hf_axi_clk.clkr,

	[GCC_DISP_XO_CLK] = &gcc_disp_xo_clk.clkr,

	[GCC_GP1_CLK] = &gcc_gp1_clk.clkr,

	[GCC_GP1_CLK_SRC] = &gcc_gp1_clk_src.clkr,

	[GCC_GP2_CLK] = &gcc_gp2_clk.clkr,
@@ -6281,7 +6252,6 @@ static struct clk_regmap *gcc_x1e80100_clocks[] = { 
	[GCC_GPLL7] = &gcc_gpll7.clkr,

	[GCC_GPLL8] = &gcc_gpll8.clkr,

	[GCC_GPLL9] = &gcc_gpll9.clkr,

	[GCC_GPU_CFG_AHB_CLK] = &gcc_gpu_cfg_ahb_clk.clkr,

	[GCC_GPU_GPLL0_CPH_CLK_SRC] = &gcc_gpu_gpll0_cph_clk_src.clkr,

	[GCC_GPU_GPLL0_DIV_CPH_CLK_SRC] = &gcc_gpu_gpll0_div_cph_clk_src.clkr,

	[GCC_GPU_MEMNOC_GFX_CLK] = &gcc_gpu_memnoc_gfx_clk.clkr,