Commit b62fbe3b authored by Javier Carrasco's avatar Javier Carrasco Committed by Jonathan Cameron
Browse files

iio: light: bh1745: fix information leak in triggered buffer 



The 'scan' local struct is used to push data to user space from a
triggered buffer, but it does not set values for inactive channels, as
it only uses iio_for_each_active_channel() to assign new values.

Initialize the struct to zero before using it to avoid pushing
uninitialized information to userspace.

Cc: stable@vger.kernel.org
Fixes: eab35358 ("iio: light: ROHM BH1745 colour sensor")
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20241125-iio_memset_scan_holes-v1-7-0cb6e98d895c@gmail.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 2a7377cc

drivers/iio/light/bh1745.c

+2 −0
Original line number Diff line number Diff line
@@ -746,6 +746,8 @@ static irqreturn_t bh1745_trigger_handler(int interrupt, void *p) 
	int i;

	int j = 0;



	memset(&scan, 0, sizeof(scan));



	iio_for_each_active_channel(indio_dev, i) {

		ret = regmap_bulk_read(data->regmap, BH1745_RED_LSB + 2 * i,

				       &value, 2);