Commit b639585e authored by Wang Jinchao's avatar Wang Jinchao Committed by Christian Brauner
Browse files

fork: Using clone_flags for legacy clone check 



In the current implementation of clone(), there is a line that
initializes `u64 clone_flags = args->flags` at the top.
This means that there is no longer a need to use args->flags
for the legacy clone check.

Signed-off-by: default avatarWang Jinchao <wangjinchao@xfusion.com>
Link: https://lore.kernel.org/r/202401311054+0800-wangjinchao@xfusion.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 6613476e

kernel/fork.c

+2 −2
Original line number Diff line number Diff line
@@ -2875,8 +2875,8 @@ pid_t kernel_clone(struct kernel_clone_args *args) 
	 * here has the advantage that we don't need to have a separate helper

	 * to check for legacy clone().

	 */

	if ((args->flags & CLONE_PIDFD) &&

	    (args->flags & CLONE_PARENT_SETTID) &&

	if ((clone_flags & CLONE_PIDFD) &&

	    (clone_flags & CLONE_PARENT_SETTID) &&

	    (args->pidfd == args->parent_tid))

		return -EINVAL;