Unverified Commit b642e081 authored Oct 30, 2023 by Yang Li Committed by Krzysztof Wilczyński Dec 18, 2023

PCI: xilinx-xdma: Remove redundant dev_err()

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

  ./drivers/pci/controller/pcie-xilinx-dma-pl.c:688:2-9: line 688 is redundant because platform_get_irq() already prints an error
  ./drivers/pci/controller/pcie-xilinx-dma-pl.c:702:2-9: line 702 is redundant because platform_get_irq() already prints an error

Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7074
Link: https://lore.kernel.org/linux-pci/20231030061242.51475-1-yang.lee@linux.alibaba.com


Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

parent b85ea95d

drivers/pci/controller/pcie-xilinx-dma-pl.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -684,10 +684,8 @@ static int xilinx_request_msi_irq(struct pl_dma_pcie *port)
		int ret;

		port->msi.irq_msi0 = platform_get_irq_byname(pdev, "msi0");
		if (port->msi.irq_msi0 <= 0) {
		dev_err(dev, "Unable to find msi0 IRQ line\n");
		if (port->msi.irq_msi0 <= 0)
		return port->msi.irq_msi0;
		}

		ret = devm_request_irq(dev, port->msi.irq_msi0, xilinx_pl_dma_pcie_msi_handler_low,
		IRQF_SHARED \| IRQF_NO_THREAD, "xlnx-pcie-dma-pl",
		@@ -698,10 +696,8 @@ static int xilinx_request_msi_irq(struct pl_dma_pcie *port)
		}

		port->msi.irq_msi1 = platform_get_irq_byname(pdev, "msi1");
		if (port->msi.irq_msi1 <= 0) {
		dev_err(dev, "Unable to find msi1 IRQ line\n");
		if (port->msi.irq_msi1 <= 0)
		return port->msi.irq_msi1;
		}

		ret = devm_request_irq(dev, port->msi.irq_msi1, xilinx_pl_dma_pcie_msi_handler_high,
		IRQF_SHARED \| IRQF_NO_THREAD, "xlnx-pcie-dma-pl",