Commit b66e2ee7 authored by Suzuki K Poulose's avatar Suzuki K Poulose Committed by Catalin Marinas
Browse files

dma: Introduce generic dma_addr_*crypted helpers 



AMD SME added __sme_set/__sme_clr primitives to modify the DMA address for
encrypted/decrypted traffic. However this doesn't fit in with other models,
e.g., Arm CCA where the meanings are the opposite. i.e., "decrypted" traffic
has a bit set and "encrypted" traffic has the top bit cleared.

In preparation for adding the support for Arm CCA DMA conversions, convert the
existing primitives to more generic ones that can be provided by the backends.
i.e., add helpers to
 1. dma_addr_encrypted - Convert a DMA address to "encrypted" [ == __sme_set() ]
 2. dma_addr_unencrypted - Convert a DMA address to "decrypted" [ None exists today ]
 3. dma_addr_canonical - Clear any "encryption"/"decryption" bits from DMA
    address [ SME uses __sme_clr() ] and convert to a canonical DMA address.

Since the original __sme_xxx helpers come from linux/mem_encrypt.h, use that
as the home for the new definitions and provide dummy ones when none is provided
by the architectures.

With the above, phys_to_dma_unencrypted() uses the newly added dma_addr_unencrypted()
helper and to make it a bit more easier to read and avoid double conversion,
provide __phys_to_dma().

Suggested-by: default avatarRobin Murphy <robin.murphy@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Steven Price <steven.price@arm.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Reviewed-by: default avatarGavin Shan <gshan@redhat.com>
Acked-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Fixes: 42be24a4 ("arm64: Enable memory encrypt for Realms")
Acked-by: default avatarWill Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20250227144150.1667735-3-suzuki.poulose@arm.com


Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent c3809317

include/linux/dma-direct.h

+8 −4
Original line number Diff line number Diff line
@@ -78,14 +78,18 @@ static inline dma_addr_t dma_range_map_max(const struct bus_dma_region *map) 
#define phys_to_dma_unencrypted		phys_to_dma

#endif

#else

static inline dma_addr_t phys_to_dma_unencrypted(struct device *dev,

		phys_addr_t paddr)

static inline dma_addr_t __phys_to_dma(struct device *dev, phys_addr_t paddr)

{

	if (dev->dma_range_map)

		return translate_phys_to_dma(dev, paddr);

	return paddr;

}



static inline dma_addr_t phys_to_dma_unencrypted(struct device *dev,

						phys_addr_t paddr)

{

	return dma_addr_unencrypted(__phys_to_dma(dev, paddr));

}

/*

 * If memory encryption is supported, phys_to_dma will set the memory encryption

 * bit in the DMA address, and dma_to_phys will clear it.
@@ -94,14 +98,14 @@ static inline dma_addr_t phys_to_dma_unencrypted(struct device *dev, 
 */

static inline dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr)

{

	return __sme_set(phys_to_dma_unencrypted(dev, paddr));

	return dma_addr_encrypted(__phys_to_dma(dev, paddr));

}



static inline phys_addr_t dma_to_phys(struct device *dev, dma_addr_t dma_addr)

{

	phys_addr_t paddr;



	dma_addr = __sme_clr(dma_addr);

	dma_addr = dma_addr_canonical(dma_addr);

	if (dev->dma_range_map)

		paddr = translate_dma_to_phys(dev, dma_addr);

	else

include/linux/mem_encrypt.h

+23 −0
Original line number Diff line number Diff line
@@ -26,11 +26,34 @@ 
 */

#define __sme_set(x)		((x) | sme_me_mask)

#define __sme_clr(x)		((x) & ~sme_me_mask)



#define dma_addr_encrypted(x)	__sme_set(x)

#define dma_addr_canonical(x)	__sme_clr(x)



#else

#define __sme_set(x)		(x)

#define __sme_clr(x)		(x)

#endif



/*

 * dma_addr_encrypted() and dma_addr_unencrypted() are for converting a given DMA

 * address to the respective type of addressing.

 *

 * dma_addr_canonical() is used to reverse any conversions for encrypted/decrypted

 * back to the canonical address.

 */

#ifndef dma_addr_encrypted

#define dma_addr_encrypted(x)		(x)

#endif



#ifndef dma_addr_unencrypted

#define dma_addr_unencrypted(x)		(x)

#endif



#ifndef dma_addr_canonical

#define dma_addr_canonical(x)		(x)

#endif



#endif	/* __ASSEMBLY__ */



#endif	/* __MEM_ENCRYPT_H__ */