Commit b6802b61 authored by Rob Clark's avatar Rob Clark Committed by Dmitry Baryshkov
Browse files

drm/crtc: fix uninitialized variable use even harder 



DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop),
which means we can't rely too much on variable initializers.

Fixes: 6e455f5d ("drm/crtc: fix uninitialized variable use")
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # sc7180, sdm845
Link: https://patchwork.freedesktop.org/patch/msgid/20240212215534.190682-1-robdclark@gmail.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent b671cd3d

drivers/gpu/drm/drm_crtc.c

+1 −0
Original line number Diff line number Diff line
@@ -904,6 +904,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, 
	connector_set = NULL;

	fb = NULL;

	mode = NULL;

	num_connectors = 0;



	DRM_MODESET_LOCK_ALL_END(dev, ctx, ret);