Commit b69165a0 authored Oct 21, 2025 by Danilo Krummrich

rust: auxiliary: move parent() to impl Device



Currently, the parent method is implemented for any Device<Ctx>, i.e.
any device context and returns a &device::Device<Normal>.

However, a subsequent patch will introduce

	impl Device<Bound> {
	    pub fn parent() -> device::Device<Bound> { ... }
	}

which takes advantage of the fact that if the auxiliary device is bound
the parent is guaranteed to be bound as well.

I.e. the behavior we want is that all device contexts that dereference
to Bound, will use the implementation above, whereas the old
implementation should only be implemented for Device<Normal>.

Hence, move the current implementation.

Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Danilo Krummrich <dakr@kernel.org>

parent e4e679c8

rust/kernel/auxiliary.rs

+2 −2

Original line number	Diff line number	Diff line
		@@ -215,15 +215,15 @@ pub fn id(&self) -> u32 {
		// `struct auxiliary_device`.
		unsafe { (*self.as_raw()).id }
		}
		}

		impl Device {
		/// Returns a reference to the parent [`device::Device`].
		pub fn parent(&self) -> &device::Device {
		// SAFETY: A `struct auxiliary_device` always has a parent.
		unsafe { self.as_ref().parent().unwrap_unchecked() }
		}
		}

		impl Device {
		extern "C" fn release(dev: *mut bindings::device) {
		// SAFETY: By the type invariant `self.0.as_raw` is a pointer to the `struct device`
		// embedded in `struct auxiliary_device`.