Commit b7033748 authored by Bob Pearson's avatar Bob Pearson Committed by Jason Gunthorpe
Browse files

RDMA/rxe: Allow good work requests to be executed 

A previous commit incorrectly added an 'if(!err)' before scheduling the
requester task in rxe_post_send_kernel(). But if there were send wrs
successfully added to the send queue before a bad wr they might never get
executed.

This commit fixes this by scheduling the requester task if any wqes were
successfully posted in rxe_post_send_kernel() in rxe_verbs.c.

Link: https://lore.kernel.org/r/20240329145513.35381-5-rpearsonhpe@gmail.com


Signed-off-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Fixes: 5bf944f2 ("RDMA/rxe: Add error messages")
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 2b23b609

drivers/infiniband/sw/rxe/rxe_verbs.c

+5 −1
Original line number Diff line number Diff line
@@ -888,6 +888,7 @@ static int rxe_post_send_kernel(struct rxe_qp *qp, 
{

	int err = 0;

	unsigned long flags;

	int good = 0;



	spin_lock_irqsave(&qp->sq.sq_lock, flags);

	while (ibwr) {
@@ -895,12 +896,15 @@ static int rxe_post_send_kernel(struct rxe_qp *qp, 
		if (err) {

			*bad_wr = ibwr;

			break;

		} else {

			good++;

		}

		ibwr = ibwr->next;

	}

	spin_unlock_irqrestore(&qp->sq.sq_lock, flags);



	if (!err)

	/* kickoff processing of any posted wqes */

	if (good)

		rxe_sched_task(&qp->req.task);



	spin_lock_irqsave(&qp->state_lock, flags);