Commit b70c7996 authored by Cristian Marussi's avatar Cristian Marussi Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Make raw debugfs entries non-seekable 



SCMI raw debugfs entries are used to inject and snoop messages out of the
SCMI core and, as such, the underlying virtual files have no reason to
support seeking.

Modify the related file_operations descriptors to be non-seekable.

Fixes: 3c3d818a ("firmware: arm_scmi: Add core raw transmission support")
Signed-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20240315140324.231830-1-cristian.marussi@arm.com


Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 17f243ad

drivers/firmware/arm_scmi/raw_mode.c

+6 −1
Original line number Diff line number Diff line
@@ -921,7 +921,7 @@ static int scmi_dbg_raw_mode_open(struct inode *inode, struct file *filp) 
	rd->raw = raw;

	filp->private_data = rd;



	return 0;

	return nonseekable_open(inode, filp);

}



static int scmi_dbg_raw_mode_release(struct inode *inode, struct file *filp)
@@ -950,6 +950,7 @@ static const struct file_operations scmi_dbg_raw_mode_reset_fops = { 
	.open = scmi_dbg_raw_mode_open,

	.release = scmi_dbg_raw_mode_release,

	.write = scmi_dbg_raw_mode_reset_write,

	.llseek = no_llseek,

	.owner = THIS_MODULE,

};
@@ -959,6 +960,7 @@ static const struct file_operations scmi_dbg_raw_mode_message_fops = { 
	.read = scmi_dbg_raw_mode_message_read,

	.write = scmi_dbg_raw_mode_message_write,

	.poll = scmi_dbg_raw_mode_message_poll,

	.llseek = no_llseek,

	.owner = THIS_MODULE,

};
@@ -975,6 +977,7 @@ static const struct file_operations scmi_dbg_raw_mode_message_async_fops = { 
	.read = scmi_dbg_raw_mode_message_read,

	.write = scmi_dbg_raw_mode_message_async_write,

	.poll = scmi_dbg_raw_mode_message_poll,

	.llseek = no_llseek,

	.owner = THIS_MODULE,

};
@@ -998,6 +1001,7 @@ static const struct file_operations scmi_dbg_raw_mode_notification_fops = { 
	.release = scmi_dbg_raw_mode_release,

	.read = scmi_test_dbg_raw_mode_notif_read,

	.poll = scmi_test_dbg_raw_mode_notif_poll,

	.llseek = no_llseek,

	.owner = THIS_MODULE,

};
@@ -1021,6 +1025,7 @@ static const struct file_operations scmi_dbg_raw_mode_errors_fops = { 
	.release = scmi_dbg_raw_mode_release,

	.read = scmi_test_dbg_raw_mode_errors_read,

	.poll = scmi_test_dbg_raw_mode_errors_poll,

	.llseek = no_llseek,

	.owner = THIS_MODULE,

};