Commit b73602bf authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

misc: eeprom_93xx46: Use string_choices API instead of ternary operator 



Use modern string_choices API instead of manually determining the
output using ternary operator.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240508184905.2102633-10-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5efcdfe

drivers/misc/eeprom/eeprom_93xx46.c

+5 −4
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#include <linux/property.h>

#include <linux/slab.h>

#include <linux/spi/spi.h>

#include <linux/string_choices.h>



#include <linux/nvmem-provider.h>
@@ -201,7 +202,7 @@ static int eeprom_93xx46_ew(struct eeprom_93xx46_dev *edev, int is_on) 
	}



	dev_dbg(&edev->spi->dev, "ew %s cmd 0x%04x, %d bits\n",

			is_on ? "en" : "ds", cmd_addr, bits);

		str_enable_disable(is_on), cmd_addr, bits);



	t.tx_buf = &cmd_addr;

	t.len = 2;
@@ -217,8 +218,8 @@ static int eeprom_93xx46_ew(struct eeprom_93xx46_dev *edev, int is_on) 
	/* have to wait at least Tcsl ns */

	ndelay(250);

	if (ret)

		dev_err(&edev->spi->dev, "erase/write %sable error %d\n",

			is_on ? "en" : "dis", ret);

		dev_err(&edev->spi->dev, "erase/write %s error %d\n",

			str_enable_disable(is_on), ret);



	gpiod_set_value_cansleep(edev->pdata->select, 0);