Commit b74c2a2e authored by Shravya KN's avatar Shravya KN Committed by Jakub Kicinski
Browse files

bnxt_en: Fix DCB ETS validation 



In bnxt_ets_validate(), the code incorrectly loops over all possible
traffic classes to check and add the ETS settings.  Fix it to loop
over the configured traffic classes only.

The unconfigured traffic classes will default to TSA_ETS with 0
bandwidth.  Looping over these unconfigured traffic classes may
cause the validation to fail and trigger this error message:

"rejecting ETS config starving a TC\n"

The .ieee_setets() will then fail.

Fixes: 7df4ae9f ("bnxt_en: Implement DCBNL to support host-based DCBX.")
Reviewed-by: default avatarSreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: default avatarShravya KN <shravya.k-n@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250710213938.1959625-2-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e81750b4

drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c

+2 −0
Original line number Diff line number Diff line
@@ -487,7 +487,9 @@ static int bnxt_ets_validate(struct bnxt *bp, struct ieee_ets *ets, u8 *tc) 


		if ((ets->tc_tx_bw[i] || ets->tc_tsa[i]) && i > bp->max_tc)

			return -EINVAL;

	}



	for (i = 0; i < max_tc; i++) {

		switch (ets->tc_tsa[i]) {

		case IEEE_8021QAZ_TSA_STRICT:

			break;