Unverified Commit b74cac09 authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno
Browse files

soc: mediatek: mtk-svs: Check if SVS mode is available in the beginning 

The svs_init01() and svs_init02() functions are already checking if the
INIT01 and INIT02 modes are available - but that's done in for loops and
for each SVS bank.

Give those a shortcut to get out early if no SVS bank features the
desired init mode: this is especially done to avoid some locking in
the svs_init01(), but also to avoid multiple for loops to check the
same, when no bank supports a specific mode.

Link: https://lore.kernel.org/r/20231121125044.78642-17-angelogioacchino.delregno@collabora.com


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent b77f0c30

drivers/soc/mediatek/mtk-svs.c

+16 −0
Original line number Diff line number Diff line
@@ -1400,6 +1400,16 @@ static irqreturn_t svs_isr(int irq, void *data) 
	return IRQ_HANDLED;

}



static bool svs_mode_available(struct svs_platform *svsp, u8 mode)

{

	int i;



	for (i = 0; i < svsp->bank_max; i++)

		if (svsp->banks[i].mode_support & mode)

			return true;

	return false;

}



static int svs_init01(struct svs_platform *svsp)

{

	struct svs_bank *svsb;
@@ -1408,6 +1418,9 @@ static int svs_init01(struct svs_platform *svsp) 
	int ret = 0, r;

	u32 opp_freq, opp_vboot, buck_volt, idx, i;



	if (!svs_mode_available(svsp, SVSB_MODE_INIT01))

		return 0;



	/* Keep CPUs' core power on for svs_init01 initialization */

	cpuidle_pause_and_lock();
@@ -1575,6 +1588,9 @@ static int svs_init02(struct svs_platform *svsp) 
	int ret;

	u32 idx;



	if (!svs_mode_available(svsp, SVSB_MODE_INIT02))

		return 0;



	for (idx = 0; idx < svsp->bank_max; idx++) {

		svsb = &svsp->banks[idx];