Commit b753b333 authored by Johannes Berg's avatar Johannes Berg Committed by Miri Korenblit
Browse files

wifi: iwlwifi: mld: don't WARN on WoWLAN suspend w/o BSS vif 



Clearly, from a user perspective, it must be valid to configure
WoWLAN (which can include network detection) and then suspend
while not connected to a network, or even without an interface
at all (WoWLAN config is handled on a per-wiphy basis). Since
mac80211 doesn't distinguish these cases and simply calls the
driver to suspend whenever WoWLAN is configured, the driver has
to cleanly handle the case where it's called for WoWLAN but no
(BSS) interface exists.

Remove the WARN_ON(), move the print so it doesn't get done in
this case, and keep returning 1 to disconnect everything.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20260515151352.0c55d1135409.I54f8be0e2aa28cfb1cb1dcf3b2d2d8fe75b4397b@changeid


Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
parent 25e416f1

drivers/net/wireless/intel/iwlwifi/mld/d3.c

+3 −3
Original line number Diff line number Diff line
@@ -1930,12 +1930,12 @@ int iwl_mld_wowlan_suspend(struct iwl_mld *mld, struct cfg80211_wowlan *wowlan) 
	if (WARN_ON(!wowlan))

		return 1;



	IWL_DEBUG_WOWLAN(mld, "Starting the wowlan suspend flow\n");



	bss_vif = iwl_mld_get_bss_vif(mld);

	if (WARN_ON(!bss_vif))

	if (!bss_vif)

		return 1;



	IWL_DEBUG_WOWLAN(mld, "Starting the wowlan suspend flow\n");



	if (!bss_vif->cfg.assoc) {

		int ret;

		/* If we're not associated, this must be netdetect */