Commit b7acfeab authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Vinod Koul
Browse files

phy: qcom: fix error code in snps_eusb2_hsphy_probe() 



When phy->ref_clk is NULL PTR_ERR(NULL) will be a success. Fix this by
using -ENOENT when phy->ref_clk is NULL instead.

Fixes: 80090810 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aDCbeuCTy9zyWJAM@stanley.mountain/


Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20250710172403.2593193-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent cf023349

drivers/phy/phy-snps-eusb2.c

+4 −2
Original line number Diff line number Diff line
@@ -567,9 +567,11 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) 
		}

	}



	if (IS_ERR_OR_NULL(phy->ref_clk))

		return dev_err_probe(dev, PTR_ERR(phy->ref_clk),

	if (IS_ERR_OR_NULL(phy->ref_clk)) {

		ret = phy->ref_clk ? PTR_ERR(phy->ref_clk) : -ENOENT;

		return dev_err_probe(dev, ret,

				     "failed to get ref clk\n");

	}



	num = ARRAY_SIZE(phy->vregs);

	for (i = 0; i < num; i++)