Commit b7c09821 authored by Chen Ni's avatar Chen Ni Committed by Miquel Raynal
Browse files

mtd: physmap_of_gemini: Fix disabled pinctrl state check 



The condition for checking the disabled pinctrl state incorrectly checks
gf->enabled_state instead of gf->disabled_state. This causes misleading
error messages and could lead to incorrect behavior when only one of the
pinctrl states is defined.

Fix the condition to properly check gf->disabled_state.

Fixes: 9d3b5086 ("mtd: physmap_of_gemini: Handle pin control")
Signed-off-by: default avatarChen Ni <nichen@iscas.ac.cn>
Reviewed-by: default avatarLinus Walleij <linusw@kernel.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 16d68d10

drivers/mtd/maps/physmap-gemini.c

+1 −1
Original line number Diff line number Diff line
@@ -181,7 +181,7 @@ int of_flash_probe_gemini(struct platform_device *pdev, 
		dev_err(dev, "no enabled pin control state\n");



	gf->disabled_state = pinctrl_lookup_state(gf->p, "disabled");

	if (IS_ERR(gf->enabled_state)) {

	if (IS_ERR(gf->disabled_state)) {

		dev_err(dev, "no disabled pin control state\n");

	} else {

		ret = pinctrl_select_state(gf->p, gf->disabled_state);